fix: try to fit message as far as possible#3466
Merged
isekovanic merged 1 commit intodevelopfrom Mar 7, 2026
Merged
Conversation
isekovanic
commented
Mar 7, 2026
| const maxTopWithoutBottom = maxY - msgH; | ||
| const maxTop = minTop <= maxTopWithBottom ? maxTopWithBottom : maxTopWithoutBottom; | ||
| const solvedTop = clamp(anchorY, minTop, Math.max(minTop, maxTop)); | ||
| const canFitBottomWithoutOverlap = minTop <= maxTopWithBottom; |
Contributor
Author
There was a problem hiding this comment.
Note for myself: At some point this should come as an overridable function, allowing more control over how these calculations work.
Contributor
SDK Size
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎯 Goal
This PR fixes an edge case where the teleported message would not properly try to fit as much as it can within the screen if the total sum of the top item height, its own height and the bottom item height would be greater than the screen height.
With this, we'll always try to animate the message as far as we can and clamp the animation to its boundaries. The bottom item will still overlap any excess height as it was before.
🛠 Implementation details
🎨 UI Changes
iOS
Android
🧪 Testing
☑️ Checklist
developbranch